Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcdaemon: StateFactory rework #2603

Merged
merged 17 commits into from
Dec 18, 2024
Merged

rpcdaemon: StateFactory rework #2603

merged 17 commits into from
Dec 18, 2024

Conversation

lupin012
Copy link
Contributor

@lupin012 lupin012 commented Dec 15, 2024 •
edited
Loading

This PR contains:

  • removed StateFactory::create_state_txn()
  • modified StateFactory::create_state() uses txn_id as input no more block_num
  • StateFactory::user_txn_id_at() new method that return txn_id from block_num and txn_index
  • modify APIs using new StateFactory interface

@lupin012 lupin012 force-pushed the state_factory_rework branch from c319688 to 2e5009e Compare December 15, 2024 16:21
@canepat canepat mentioned this pull request Dec 15, 2024
Open
39 tasks
@lupin012 lupin012 marked this pull request as ready for review December 17, 2024 13:38
@lupin012 lupin012 requested a review from canepat December 17, 2024 13:39
canepat
canepat requested changes Dec 18, 2024
View reviewed changes
@canepat canepat added maintenance Some maintenance work (fix, refactor, rename, test...) erigon3 Erigon3 feature labels Dec 18, 2024
@lupin012 lupin012 requested a review from canepat December 18, 2024 19:17
@canepat canepat changed the title rpcdaemon: State factory rework rpcdaemon: StateFactory rework Dec 18, 2024
@canepat canepat merged commit 5e69657 into master Dec 18, 2024
5 checks passed
@canepat canepat deleted the state_factory_rework branch December 18, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canepat canepat canepat approved these changes

Assignees
No one assigned
Labels
erigon3 Erigon3 feature maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lupin012 @canepat @web-flow