db: fix datastore namespaces #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparation before adding DHII into datastore/mdbx.
Everything inside datastore/mdbx should have the same namespace independent of silkworm::db.
The silkworm::db contains DAL while datastore/mdbx contains the datastore implementation.
* move top level datastore items to silkworm::datastore
* move items in datastore/mdbx from silkworm::db to silkworm::sw_mdbx
* move items in datastore/etl to silkworm::etl
Note 1: a name "sw_mdbx" is chosen to avoid a conflict with ::mdbx own namespace.
Note 2: code that uses access_layer.hpp or stage.hpp will use aliases of ROTxn/RWTxn inside silkworm::db namespace.
This is done to avoid extra churn in code that we don't actively support.
battlmonstr
force-pushed
the
pr/dhii_mdbx
branch
from
7fdc968 to
9f0f276
Compare
canepat
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation before adding DHII into datastore/mdbx. Everything inside datastore/mdbx should have the same namespace independent of silkworm::db. The silkworm::db contains DAL while datastore/mdbx contains the datastore implementation.
Note 1: a name "kvdb" is chosen to avoid a conflict with ::mdbx own namespace, and potential confusion, given that it will be more than just mdbx wrappers there.
Note 2: code that uses access_layer.hpp or stage.hpp will use aliases of ROTxn/RWTxn inside silkworm::db namespace.
This is done to avoid extra churn in code that we don't actively support.