db: move LocalState/RemoteState to execution, StateReader to kv #2557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db/state module is being repurposed for the low level e3 state implementation. It contains the eth state implementation that is not generic enough to be in db/datastore (akin SharedDomains vs Aggregator split in erigon). "low level" means that db/state must not depend on db/kv API.
In relation to this 2 refactorings are made:
db::kv::api::Transaction::create_state
method is replaced with execution::StateFactory. Now kv::api::Transaction is more decoupled from the EVM execution needs, and more closely represents the temporal KV API.As a result, db/state does not depend on db/kv anymore. On the contrary, it is now possible to put code in db/kv that depends on db/state as needed.