Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: unify transaction validation for execution and simulate paths #2542

Merged

Conversation

bzawisto
Copy link
Contributor

@bzawisto bzawisto commented Nov 28, 2024

This is an attempt to merge common code paths for both pre_validate_transaction and call_pre_check.

@bzawisto bzawisto linked an issue Nov 28, 2024 that may be closed by this pull request
@bzawisto bzawisto changed the title [WIP] Some progress towawrds unification [WIP] Some progress towards unification Nov 28, 2024
@bzawisto bzawisto marked this pull request as draft November 28, 2024 12:54
@bzawisto bzawisto changed the title [WIP] Some progress towards unification Unify transaction validation for execution and simulate paths Dec 2, 2024
@bzawisto bzawisto marked this pull request as ready for review December 2, 2024 14:12
@bzawisto bzawisto requested a review from canepat December 2, 2024 14:13
@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Dec 3, 2024
@canepat canepat changed the title Unify transaction validation for execution and simulate paths core: unify transaction validation for execution and simulate paths Dec 3, 2024
@canepat canepat merged commit 648cb53 into master Dec 3, 2024
6 checks passed
@canepat canepat deleted the 2522-core-deduplicate-transaction-vs-call-validation-code branch December 3, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: deduplicate transaction vs call validation code
2 participants