Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: always pass TemporaryDirectory to TestDatabaseContext #2475

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

battlmonstr
Copy link
Contributor

This is a consistency refactoring so that each test manages its own TemporaryDirectory. TemporaryDirectory manages its cleanup.

@battlmonstr battlmonstr requested a review from canepat November 4, 2024 11:58
Base automatically changed from pr/data_store1 to master November 5, 2024 12:26
This is a consistency refactoring so that each test manages its own TemporaryDirectory.
TemporaryDirectory manages its cleanup.
@battlmonstr battlmonstr marked this pull request as ready for review November 5, 2024 13:01
@battlmonstr battlmonstr enabled auto-merge (squash) November 5, 2024 17:23
@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Nov 5, 2024
@battlmonstr battlmonstr merged commit 21fcefb into master Nov 5, 2024
6 checks passed
@battlmonstr battlmonstr deleted the pr/dbctxtmp branch November 5, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants