Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcdaemon: fix clang tidy after PR 2417 #2425

Merged
merged 2 commits into from
Oct 16, 2024
Merged

rpcdaemon: fix clang tidy after PR 2417 #2425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
427b07c
fix clang tidy after PR 2417
lupin012 Oct 16, 2024
666b174
remove unused using
lupin012 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions silkworm/rpc/commands/rpc_api_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,11 @@

namespace silkworm::rpc::commands {

#ifdef notdef // commented Temporary wating implementaion local-transaction
using silkworm::test_util::SetLogVerbosityGuard;
using test_util::RequestHandlerForTest;
using test_util::RpcApiTestBase;
#endif

// Function to recursively sort JSON arrays
void sort_array(nlohmann::json& jsonObj) { // NOLINT(*-no-recursion)
Expand Down
1 change: 0 additions & 1 deletion silkworm/rpc/core/evm_executor_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ using db::chain::RemoteChainStorage;
using db::kv::api::KeyValue;
using testing::_;
using testing::Invoke;
using testing::InvokeWithoutArgs;
using testing::Unused;

struct EVMExecutorTest : public test_util::ServiceContextTestBase {
Expand Down
24 changes: 12 additions & 12 deletions silkworm/rpc/core/evm_trace_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2280,19 +2280,19 @@ TEST_CASE_METHOD(TraceCallExecutorTest, "TraceCallExecutor::trace_replayTransact
EXPECT_CALL(*cursor1, last()).WillOnce(Invoke([=]() -> Task<kv::api::KeyValue> {
co_return *from_hex("0000000000000000");
}));
EXPECT_CALL(transaction, domain_get(std::move(query1))).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
EXPECT_CALL(transaction, domain_get(silkworm::db::kv::api::DomainPointQuery{query1})).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
db::kv::api::DomainPointResult response{
.success = true,
.value = kAccountHistoryValue1};
co_return response;
}));
EXPECT_CALL(transaction, domain_get(std::move(query2))).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
EXPECT_CALL(transaction, domain_get(silkworm::db::kv::api::DomainPointQuery{query2})).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
db::kv::api::DomainPointResult response{
.success = false,
.value = Bytes{}};
co_return response;
}));
EXPECT_CALL(transaction, domain_get(std::move(query3))).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
EXPECT_CALL(transaction, domain_get(silkworm::db::kv::api::DomainPointQuery{query3})).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
db::kv::api::DomainPointResult response{
.success = true,
.value = kAccountHistoryValue3};
Expand Down Expand Up @@ -2633,19 +2633,19 @@ TEST_CASE_METHOD(TraceCallExecutorTest, "TraceCallExecutor::trace_replayTransact
EXPECT_CALL(*cursor2, last()).WillOnce(Invoke([=]() -> Task<kv::api::KeyValue> {
co_return *from_hex("0000000000000000");
}));
EXPECT_CALL(transaction, domain_get(std::move(query1))).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
EXPECT_CALL(transaction, domain_get(silkworm::db::kv::api::DomainPointQuery{query1})).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
db::kv::api::DomainPointResult response{
.success = true,
.value = kAccountHistoryValue1};
co_return response;
}));
EXPECT_CALL(transaction, domain_get(std::move(query2))).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
EXPECT_CALL(transaction, domain_get(silkworm::db::kv::api::DomainPointQuery{query2})).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
db::kv::api::DomainPointResult response{
.success = false,
.value = Bytes{}};
co_return response;
}));
EXPECT_CALL(transaction, domain_get(std::move(query3))).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
EXPECT_CALL(transaction, domain_get(silkworm::db::kv::api::DomainPointQuery{query3})).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
db::kv::api::DomainPointResult response{
.success = true,
.value = kAccountHistoryValue3};
Expand Down Expand Up @@ -2700,19 +2700,19 @@ TEST_CASE_METHOD(TraceCallExecutorTest, "TraceCallExecutor::trace_replayTransact
EXPECT_CALL(*cursor2, last()).WillOnce(Invoke([=]() -> Task<kv::api::KeyValue> {
co_return *from_hex("0000000000000000");
}));
EXPECT_CALL(transaction, domain_get(std::move(query1))).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
EXPECT_CALL(transaction, domain_get(silkworm::db::kv::api::DomainPointQuery{query1})).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
db::kv::api::DomainPointResult response{
.success = true,
.value = kAccountHistoryValue1};
co_return response;
}));
EXPECT_CALL(transaction, domain_get(std::move(query2))).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
EXPECT_CALL(transaction, domain_get(silkworm::db::kv::api::DomainPointQuery{query2})).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
db::kv::api::DomainPointResult response{
.success = false,
.value = Bytes{}};
co_return response;
}));
EXPECT_CALL(transaction, domain_get(std::move(query3))).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
EXPECT_CALL(transaction, domain_get(silkworm::db::kv::api::DomainPointQuery{query3})).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
db::kv::api::DomainPointResult response{
.success = true,
.value = kAccountHistoryValue3};
Expand Down Expand Up @@ -2790,19 +2790,19 @@ TEST_CASE_METHOD(TraceCallExecutorTest, "TraceCallExecutor::trace_replayTransact
EXPECT_CALL(*cursor2, last()).WillOnce(Invoke([=]() -> Task<kv::api::KeyValue> {
co_return *from_hex("0000000000000000");
}));
EXPECT_CALL(transaction, domain_get(std::move(query1))).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
EXPECT_CALL(transaction, domain_get(silkworm::db::kv::api::DomainPointQuery{query1})).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
db::kv::api::DomainPointResult response{
.success = true,
.value = kAccountHistoryValue1};
co_return response;
}));
EXPECT_CALL(transaction, domain_get(std::move(query2))).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
EXPECT_CALL(transaction, domain_get(silkworm::db::kv::api::DomainPointQuery{query2})).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
db::kv::api::DomainPointResult response{
.success = false,
.value = Bytes{}};
co_return response;
}));
EXPECT_CALL(transaction, domain_get(std::move(query3))).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
EXPECT_CALL(transaction, domain_get(silkworm::db::kv::api::DomainPointQuery{query3})).WillRepeatedly(Invoke([=](Unused) -> Task<db::kv::api::DomainPointResult> {
db::kv::api::DomainPointResult response{
.success = true,
.value = kAccountHistoryValue3};
Expand Down
Loading