execution: fix silkworm_capi_test on macOS (#2389) #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-fno-exceptions flag renders all code as noexcept, even methods that are not marked noexcept.
In particular, virtual methods that are provided to core as abstract interfaces, but implemented in db and node can throw.
Keep the strict flag only for WASM ("core only") builds.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2412 +/- ##
==========================================
+ Coverage 52.85% 52.87% +0.01%
==========================================
Files 728 728
Lines 49932 49932
Branches 7570 7570
==========================================
+ Hits 26392 26400 +8
+ Misses 21221 21209 -12
- Partials 2319 2323 +4 ☔ View full report in Codecov by Sentry. |
canepat
approved these changes
Oct 9, 2024
canepat
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-fno-exceptions flag renders all code as noexcept, even methods that are not marked noexcept. In particular, virtual methods that are provided to core as abstract interfaces, but implemented in db and node can throw.
Keep the strict flag only for WASM ("core only") builds.