Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding deneb p2p containers #7401

Merged
merged 2 commits into from
Apr 29, 2023
Merged

adding deneb p2p containers #7401

merged 2 commits into from
Apr 29, 2023

Conversation

enriavil1
Copy link
Contributor

This PR adds the new p2p containers from Deneb into Caplin
#7389

@enriavil1 enriavil1 changed the title adding deneb containers adding deneb p2p containers Apr 28, 2023
Giulio2002
Giulio2002 approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@Giulio2002 Giulio2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Giulio2002
Copy link
Contributor

cannot get the tests to run on windows trying again

@enriavil1
Copy link
Contributor Author

cannot get the tests to run on windows trying again

I think a window test might be broken or is shaky. I don't think the tests I added are failing on windows

@Giulio2002 Giulio2002 merged commit f363eb1 into erigontech:devel Apr 29, 2023
@Giulio2002
Copy link
Contributor

it is not related to your PR

@enriavil1 enriavil1 deleted the adding-blob-side-car branch April 30, 2023 14:37
@VBulikov VBulikov mentioned this pull request Feb 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Giulio2002 Giulio2002 Giulio2002 approved these changes

Assignees
No one assigned
Labels
Dencun
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enriavil1 @Giulio2002 @VBulikov @yperbasis