Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc.txfeecap is not being respected #10582

Closed
eldarbogdanov opened this issue May 31, 2024 · 0 comments · Fixed by #10636
Closed

rpc.txfeecap is not being respected #10582

eldarbogdanov opened this issue May 31, 2024 · 0 comments · Fixed by #10636
Assignees
Milestone

Comments

@eldarbogdanov
Copy link

eldarbogdanov commented May 31, 2024

Attempting to send transaction through eth_sendRawTransaction with tx fee above 1 ether fails with txFee ... exceeds the configuration cap error, in spite of Erigon client running with unlimited cap (--rpc.txfeecap 0). The code looks like it's using the default RPCTxFeeCap instead of the user-provided one.

System information

Erigon version: any

Erigon Command (with flags/config): erigon --rpc.txfeecap 0 ... yadayadayada ...

Chain/Network: Amoy

Expected behaviour

eth_sendRawTransaction should allow providing fees above the user-configured rpc.txfeecap limit.

Actual behaviour

eth_sendRawTransaction caps fees at the default (1 ether) and fails with txFee ... exceeds the configuration cap (1.00 ether).

Steps to reproduce the behaviour

Run the client with non-default rpc.txfeecap and run eth_sendRawTransaction with fee above this default.

@shohamc1 shohamc1 self-assigned this Jun 2, 2024
shohamc1 added a commit that referenced this issue Jun 6, 2024
shohamc1 added a commit that referenced this issue Jun 6, 2024
@yperbasis yperbasis added this to the 2.60.2-fixes milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants