move DiscardHistory - from runtime to Schema (#14026)

slowly reducing amount of private method used by SharedDomains
erigontech · Mar 1, 2025 · 56dc96e · 56dc96e
1 parent 7c788fe
commit 56dc96e
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 12 deletions.
diff --git a/erigon-lib/state/aggregator.go b/erigon-lib/state/aggregator.go
@@ -326,16 +326,6 @@ func (a *Aggregator) SetCompressWorkers(i int) {
 	}
 }
 
-func (a *Aggregator) DiscardHistory(name kv.Domain) *Aggregator {
-	a.d[name].historyDisabled = true
-	return a
-}
-
-func (a *Aggregator) EnableHistory(name kv.Domain) *Aggregator {
-	a.d[name].historyDisabled = false
-	return a
-}
-
 func (a *Aggregator) HasBackgroundFilesBuild2() bool {
 	return a.buildingFiles.Load() || a.mergingFiles.Load()
 }

diff --git a/erigon-lib/state/aggregator2.go b/erigon-lib/state/aggregator2.go
@@ -150,6 +150,7 @@ var Schema = map[kv.Domain]domainCfg{
 			historyLargeValues: false,
 			filenameBase:       kv.CommitmentDomain.String(),
 			historyIdx:         kv.CommitmentHistoryIdx,
+			historyDisabled:    true,
 
 			iiCfg: iiCfg{
 				keysTable: kv.TblCommitmentHistoryKeys, valuesTable: kv.TblCommitmentIdx,

diff --git a/erigon-lib/state/domain_shared.go b/erigon-lib/state/domain_shared.go
@@ -120,8 +120,6 @@ func NewSharedDomains(tx kv.Tx, logger log.Logger) (*SharedDomains, error) {
 	sd.SetTx(tx)
 	sd.iiWriters = make([]*invertedIndexBufferedWriter, len(sd.aggTx.iis))
 
-	sd.aggTx.a.DiscardHistory(kv.CommitmentDomain)
-
 	for id, ii := range sd.aggTx.iis {
 		sd.iiWriters[id] = ii.NewWriter()
 	}