Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: avoid resampling errors in polylines cf #830 #822

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

jcrivenaes
Copy link
Collaborator

Occurs in cornercases where e.g. well sections are vertical. The fix is to allow scipy interp1d() to extrapolate. Also add and improve tests.

@ertomatic
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one minor comment only 👍

@@ -235,6 +242,7 @@ def _rescale_v2(self, distance, addlen, kind="slinear", mode2d=True):

dfr = pd.concat(dfrlist)
self.dataframe = dfr.reset_index(drop=True)
# print(self.dataframe)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

Occurs in cornercases where e.g. well sections are
vertical. The fix is to allow scipy interp1d() to extrapolate.
Also add and improve tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants