Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: re-activate yflip on Irap export #1303

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

jcrivenaes
Copy link
Collaborator

@jcrivenaes jcrivenaes commented Feb 24, 2025

Seems that taken yflip into account when exporting Irap binary/ascii was missing.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.21%. Comparing base (0375fed) to head (74a0c3c).
Report is 70 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1303      +/-   ##
==========================================
+ Coverage   80.02%   81.21%   +1.18%     
==========================================
  Files          98       94       -4     
  Lines       13680    12374    -1306     
  Branches     2203     1865     -338     
==========================================
- Hits        10948    10049     -899     
+ Misses       1999     1672     -327     
+ Partials      733      653      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@slangeveld slangeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcrivenaes jcrivenaes merged commit bea8d51 into equinor:main Feb 24, 2025
35 checks passed
@jcrivenaes jcrivenaes deleted the bug-yflip-regsurf-irap branch February 24, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants