Sort the responses and parameter views #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frode-aarstad
force-pushed
the
sort-parmas
branch
4 times, most recently
from
9316d4a to
cc26dc2
Compare
DanSava
previously approved these changes
Mar 14, 2022
| @@ -127,7 +127,8 @@ def update_graph( | |||
|
|
|||
| def _generate_plot(ensemble_id: str, color: str) -> ResponsePlotModel: | |||
| ensemble = load_ensemble(parent, ensemble_id) | |||
| plot = _create_misfits_plot(ensemble.responses[response], [], color) | |||
| resp = ensemble.responses[str(response)] | |||
There was a problem hiding this comment.
Is this refactoring really needed? Also, why is the string conversion required ? str(response)?
There was a problem hiding this comment.
If I did not explicitly cast to string the type-check would complain about the Optional[str] type
There was a problem hiding this comment.
Still, something is fishy here that you had to explicitly cast to string... Any way this function is a bit messy I think it should be refactored in the future such that it does not take response from the outer scope but it should expect a response name as part of the function arguments.
DanSava
dismissed
their stale review
Ups did not want to approve just wanted to finish the review
frode-aarstad
force-pushed
the
sort-parmas
branch
8 times, most recently
from
1a356a1 to
eca2ef3
Compare
frode-aarstad
force-pushed
the
sort-parmas
branch
from
eca2ef3 to
bc10520
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #231