Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove record data index sorting not really needed #201

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

DanSava
Copy link
Collaborator

@DanSava DanSava commented Dec 8, 2021

Issue
Index sorting is also prone to issues when sorting ints that have been converted to strings

Resolves: #195

…issues when sorting ints that have been converted to strings
@DanSava DanSava self-assigned this Dec 8, 2021
@frode-aarstad
Copy link
Contributor

I am not really able to reproduce what this was supposed to fix. I remember @DanSava showing a webviz plot that had this problem when discussing perfomance. Could you please tell me how you made that dataset.

@oysteoh
Copy link
Contributor

oysteoh commented Dec 9, 2021

I am not really able to reproduce what this was supposed to fix. I remember @DanSava showing a webviz plot that had this problem when discussing perfomance. Could you please tell me how you made that dataset.

At least I can reproduce and verify it is actually working. I edited the poly-case to run ensemble_experiment with 20 iterations instead of 10. In the Plot Viewer select the ensemble and then the response poly_res@0. Without Dan's fix i will get the x-axis like this 0, 1, 10, 11 ... 19, 2 .. 9 - with Dan's fix it is in the correct order.

@DanSava DanSava merged commit 27495b9 into equinor:master Dec 9, 2021
@DanSava DanSava deleted the no_index_sorting branch February 7, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X-axis on parameters in the plot view is not ordered correctly
3 participants