New plotting page #110

ManInFez · 2021-01-26T07:46:38Z

This is the start of having a single page, and user defined layout of various plots (param distributions, response plots, etc...). As of now only response plots are visible.

New selection widget should be included as soon as parallel coord is merged

Persistence for ensemble selector and response selector is now working (sort of)

resolves #72

autt

I like this new way of selecting multiple responses! How about adding a label with the response name to each plot, so its clear which plot is showing which response when multiple responses are selected?

xjules · 2021-02-01T12:49:40Z

ertviz/assets/ert-style.json

@@ -107,7 +107,7 @@
            "margin": {
                "l": 5,
                "b": 5,
-                "t": 5,
+                "t": 25,


So we want to increase margin?

yes the menu was covering the top plot in the legend

autt · 2021-02-01T12:52:47Z

ertviz/controllers/ensemble_selector_controller.py

-        n_clicks = 0 if n_clicks is None else n_clicks
-        if n_clicks % 2 == 0:
+    def update_ensemble_selector_view_size(
+        n_clicks, class_name, class_name_container, maximized


Looks like n_clicks is not in use anymore, maybe it can be replaced by underscore?

xjules · 2021-02-01T13:18:07Z

ertviz/controllers/ensemble_selector_controller.py

@@ -58,7 +58,10 @@ def update_ensemble_selector(selected_ensembles, _, elements):
        ctx = dash.callback_context
        triggered_id = ctx.triggered[0]["prop_id"].split(".")[0]

-        if triggered_id == parent.uuid("ensemble-selection-store"):
+        if (


Could you, maybe, make the function name more descriptive for update_ensemble_selector? Function update_ensemble_selection is fine!

renamed to update_ensemble_selector_graph

autt · 2021-02-01T13:27:52Z

ertviz/controllers/plot_view_controller.py

@@ -0,0 +1,88 @@
+# Could go into seperate file


I guess this comment can be removed now?

autt · 2021-02-01T13:42:18Z

ertviz/controllers/multi_parameter_controller.py

    )
-    def update_parameter_options(selected_ensembles):
+    def update_parameter_options(selected_ensembles, _, prev_plot_selection):


Do we want an underscore prefix here? (And on the rest of all callback functions?)

I would actually rather have it only on functions in the files that are not callbacks ;)

I think that makes sense 👍 I was just wondering as some callback functions has underscore prefixes and some does not.

I made a commit to clean up the style :)

Nice! I like consistency 👍

xjules · 2021-02-01T13:49:39Z

ertviz/controllers/ensemble_selector_controller.py

@@ -73,6 +76,7 @@ def update_ensemble_selector(selected_ensembles, _, elements):
                element["data"].update(


~~This updates ensemble regardless it's selected or not, is it intentional?~~ Ok, got it now :)

yes, because it should remove the color if it is not selected

Sure, I deleted the comment as I grasped the code in the end :)

xjules · 2021-02-01T15:07:09Z

ertviz/controllers/multi_parameter_controller.py

        if not selected_ensembles:
            raise PreventUpdate
-
        if dash.callback_context.triggered[0]["prop_id"].split(".")[0] == parent.uuid(


The parameter-selector is not longer among inputs, so can go away I reckon.

It has already been removed 🤷

I still see it there though:

if dash.callback_context.triggered[0]["prop_id"].split(".")[0] == parent.uuid( "parameter-selector" ): bin_count = None

removed now

xjules · 2021-02-01T20:45:52Z

ertviz/controllers/multi_parameter_controller.py

    )
-    def _update_histogram(parameter, hist_check_values, bin_count, selected_ensembles):
+    def update_histogram(


Where's the prior checkbox gone?

Now, the check-box prior is there again - weird ... need to do some more tests or it might be some caching issue :)

xjules · 2021-02-01T21:21:05Z

Could you also replace in multi_response_controller.py (in func. def _get_realizations_statistics_plots)

style.update({"line": {"color": color}})

which actually overwrites the entire line style just the color only

to:

style["line"]["color"] = color
style_mean = deepcopy(style)
style_mean["line"]["dash"] = "solid"

while updating the mean

mean_data = PlotModel(
        x_axis=x_axis, y_axis=_mean, text="Mean", name="Mean", **style_mean
)

ManInFez · 2021-02-02T06:28:23Z

Could you also replace in multi_response_controller.py (in func. def _get_realizations_statistics_plots)
style.update({"line": {"color": color}})
which actually overwrites the entire line style just the color only

to:
style["line"]["color"] = color
style_mean = deepcopy(style)
style_mean["line"]["dash"] = "solid"
while updating the mean
mean_data = PlotModel(
        x_axis=x_axis, y_axis=_mean, text="Mean", name="Mean", **style_mean
)

I thnk this is outside the scope of this issue..... it is already quite big

oysteoh · 2021-02-02T07:08:15Z

Looks very good! One "annoying" thing - at least for me - is that i really want an opportunity to shuffle around the charts after i've added what i want.... 🤔 Not sure if it is possible or wise to this right now, just a thought i had while using it 😄

ManInFez · 2021-02-02T07:10:48Z

I do not think that will be possible with setup as it is today.. Could be something to investigate in the future

xjules · 2021-02-02T08:12:19Z

ertviz/controllers/plot_view_controller.py

+        parameters = [] if not parameters else parameters
+        responses = [] if not responses else responses
+        current_selection = [] if not current_selection else current_selection
+        for plot in current_selection.copy():


How does this work? Is the copy created upfront or every cycle a new copy?

Only in the beginning

Add integration test for new plotting page

xjules

Tested and worked smoothly! Very good job!

ManInFez changed the title ~~New plotting page~~ WIP: New plotting page Jan 26, 2021

autt reviewed Jan 27, 2021

View reviewed changes

ManInFez force-pushed the new-plotting-page branch 2 times, most recently from 52a8c6f to 26430cd Compare February 1, 2021 09:53

ManInFez added 2 commits February 1, 2021 11:00

Add bootstrap grid to webviz-ert

4804eb1

Update ert-style

95e8ee5

ManInFez force-pushed the new-plotting-page branch 2 times, most recently from 25f5360 to 2a137ee Compare February 1, 2021 10:40

ManInFez changed the title ~~WIP: New plotting page~~ New plotting page Feb 1, 2021

ManInFez mentioned this pull request Feb 1, 2021

Make pages in webviz-ert persistent #62

Closed

ManInFez force-pushed the new-plotting-page branch 3 times, most recently from 7a8e5ca to 5076b88 Compare February 1, 2021 12:06

xjules reviewed Feb 1, 2021

View reviewed changes

autt reviewed Feb 1, 2021

View reviewed changes

xjules reviewed Feb 1, 2021

View reviewed changes

ManInFez added 4 commits February 1, 2021 14:30

Add session persistence to ensemble-selector

af1e5f9

Use figure style for histogram plot

24d8a81

Move response and misfit views in separate files

1870622

add selenium stage

ce70587

ManInFez force-pushed the new-plotting-page branch 2 times, most recently from 78d4f25 to 4ce78cb Compare February 1, 2021 13:43

autt reviewed Feb 1, 2021

View reviewed changes

xjules reviewed Feb 1, 2021

View reviewed changes

ManInFez force-pushed the new-plotting-page branch 2 times, most recently from c737a41 to 7cdd4e4 Compare February 1, 2021 14:00

xjules reviewed Feb 1, 2021

View reviewed changes

ManInFez force-pushed the new-plotting-page branch from 92c2008 to 49a314f Compare February 2, 2021 07:54

xjules reviewed Feb 2, 2021

View reviewed changes

ManInFez added 4 commits February 2, 2021 09:21

Add new plotting page with customizable session persistence setup

09b8a20

Add integration test for new plotting page

Remove outdated plugin

82f8977

unified callback function style

c250590

Fix statistics plot style

7b4e9ed

ManInFez force-pushed the new-plotting-page branch from 49a314f to 7b4e9ed Compare February 2, 2021 08:21

xjules approved these changes Feb 2, 2021

View reviewed changes

Set selenium options

743dfca

ManInFez force-pushed the new-plotting-page branch from 92aeb45 to 743dfca Compare February 2, 2021 08:35

ManInFez merged commit 361c548 into master Feb 2, 2021

ManInFez deleted the new-plotting-page branch February 2, 2021 08:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New plotting page #110

New plotting page #110

ManInFez commented Jan 26, 2021 •

edited

Loading

autt left a comment

xjules Feb 1, 2021

ManInFez Feb 1, 2021

autt Feb 1, 2021

ManInFez Feb 1, 2021

xjules Feb 1, 2021

ManInFez Feb 1, 2021

autt Feb 1, 2021

ManInFez Feb 1, 2021

autt Feb 1, 2021

ManInFez Feb 1, 2021

autt Feb 1, 2021

ManInFez Feb 1, 2021

autt Feb 1, 2021

xjules Feb 1, 2021 •

edited

Loading

ManInFez Feb 1, 2021

xjules Feb 1, 2021

xjules Feb 1, 2021

ManInFez Feb 1, 2021

xjules Feb 1, 2021

ManInFez Feb 2, 2021

xjules Feb 1, 2021

xjules Feb 1, 2021

xjules commented Feb 1, 2021

ManInFez commented Feb 2, 2021

oysteoh commented Feb 2, 2021

ManInFez commented Feb 2, 2021

xjules Feb 2, 2021

ManInFez Feb 2, 2021

xjules left a comment

		@@ -73,6 +76,7 @@ def update_ensemble_selector(selected_ensembles, _, elements):
		element["data"].update(

New plotting page #110

New plotting page #110

Conversation

ManInFez commented Jan 26, 2021 • edited Loading

autt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xjules Feb 1, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xjules commented Feb 1, 2021

ManInFez commented Feb 2, 2021

oysteoh commented Feb 2, 2021

ManInFez commented Feb 2, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xjules left a comment

Choose a reason for hiding this comment

ManInFez commented Jan 26, 2021 •

edited

Loading

xjules Feb 1, 2021 •

edited

Loading