Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added publishing of npm package to GitHub workflow #96

Merged

Conversation

rubenthoms
Copy link
Collaborator

@rubenthoms rubenthoms commented Mar 22, 2021

Added build and publish step to GitHub workflow file.

This closes #95.

@rubenthoms rubenthoms force-pushed the Added-npm-publishing-to-workflow branch 3 times, most recently from 05f1a24 to d10e2f5 Compare March 22, 2021 13:28
@rubenthoms rubenthoms requested a review from anders-kiaer March 22, 2021 13:55
@rubenthoms rubenthoms force-pushed the Added-npm-publishing-to-workflow branch from d10e2f5 to 7c76458 Compare March 22, 2021 14:06
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Some comments/questions below.

- Changed package name to be in project scope
- Adjusted Python code to ready package name accordingly
@rubenthoms rubenthoms force-pushed the Added-npm-publishing-to-workflow branch from 7c76458 to 5b73579 Compare March 26, 2021 15:15
@anders-kiaer anders-kiaer self-requested a review March 26, 2021 15:17
@rubenthoms rubenthoms merged commit 1aafcd9 into equinor:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

npm deploy on release
2 participants