Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added table download to DataTable and PivotTable #644

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

asnyv
Copy link
Collaborator

@asnyv asnyv commented Nov 8, 2022

Contributor checklist

  • 🎉 This PR closes Download data functionality needed for the DataTable plugin #570.

    • Added to PivotTable in addition to DataTable in the original issue.
  • 📜 I have broken down my PR into the following tasks:

    • Added download to DataTable.
    • Added download to PivotTable.
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.

    • Only tested manually
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

    • Added to changelog

@asnyv asnyv added the enhancement 🚀 New feature or request label Nov 8, 2022
@asnyv asnyv self-assigned this Nov 8, 2022
@asnyv asnyv force-pushed the datatable_download branch from 210bf7d to 1fa0f2c Compare November 8, 2022 08:54
@asnyv asnyv force-pushed the datatable_download branch from 38e7fbf to bc2cc96 Compare November 14, 2022 11:15
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@asnyv asnyv merged commit 86adc37 into equinor:master Nov 14, 2022
@asnyv asnyv deleted the datatable_download branch November 14, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request
Projects
Status: Done 🏁
Development

Successfully merging this pull request may close these issues.

Download data functionality needed for the DataTable plugin
2 participants