Introducing Webviz Layout Framework (WLF) #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut-jorgen' into EQ_578-new-plugin-layout
Co-authored-by: Jørgen Herje <jorgen.herje@ceetronsolutions.com>
…ator for layout property
…ut-jorgen' into EQ_578-new-plugin-layout
- Plugin download has issues for views not active - ids are not existing! Consider adjusting download per View instead of entire Plugin?
…ew-plugin-layout-download-action
…Q_578-new-plugin-layout
…ut' into EQ_578-new-plugin-layout
rubenthoms
requested review from
anders-kiaer,
HansKallekleiv and
asnyv
as code owners
…Q_578-new-plugin-layout
HansKallekleiv
approved these changes
Jun 17, 2022
This was referenced Jun 24, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #578, this PR introduces all Python classes and changes to the application template required by the new Webviz Layout Framework (WLF). That is (not exclusively):
_plugin_abc.pywhile not introducing breaking changes_layout_base_abc.py: A base class for all new WLF classes_layout_unique_id.py: A class for handling unique IDs for all new WLF instances_settings_group_abc.py: A base class for implementing settings groups_views.py: Base classes for view elements, layout elements and viewswebviz_template.py.jinja2: Implementing new structure with React components from Introducing Webviz Layout Framework (WLF) webviz-core-components#219example_content_wrapper_plugin.pyℹ️ This PR depends on equinor/webviz-core-components#219