Implemented title option for BannerImage plugin #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented the option to choose if the title of the Banner Image should stay on the top, on the bottom, or on the center. Previously, the title would always be placed in the center of the Image.
We are asking the user to pass if they want the text to be placed on the top or on the bottom of the image (center is the default). Therefore, align-items is passed on the style on the and, because of that, this property was removed from the .
izzy-el
requested review from
anders-kiaer,
asnyv and
HansKallekleiv
as code owners
anders-kiaer
requested changes
Jan 19, 2022
There was a problem hiding this comment.
Nice @izzy-el - this looks almost ready to merge 🎉 One small comment below, and perhaps add a short changelog entry in ./CHANGELOG.md?
izzy-el
changed the title
Implemented a try-except block for catching a KeyError and replaced the if statement by a constant dictionary.
anders-kiaer
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
Great @izzy-el - thanks for the contribution 🎉 We will include this in the upcoming pre-release and release.
|
Thank you! I appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now specify if they want the image to be placed on the top or on the bottom of the BannerImage (center is the default). This is done by the css property
align-items.Contributor checklist
align-itemsproperty on_banner_image.py.align-itemsfromwebviz_config.css.CHANGELOG.md, and added it if should be communicated there.