Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed syntax highlighting of code blocks in markdown #532

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

anders-kiaer
Copy link
Collaborator

@anders-kiaer anders-kiaer commented Oct 7, 2021

@anders-kiaer anders-kiaer marked this pull request as ready for review October 7, 2021 17:06
@anders-kiaer anders-kiaer requested a review from rnyb October 7, 2021 17:06
@anders-kiaer anders-kiaer added bug 🐛 Something isn't working next release 🚢 To be included in next release labels Oct 7, 2021
@anders-kiaer anders-kiaer self-assigned this Oct 7, 2021
@asnyv
Copy link
Collaborator

asnyv commented Oct 8, 2021

The fix seems good to me, but maybe change the title? It was the fenced code / code blocks that didn't work (so not inline). Inline highlighting (single `) worked already

@anders-kiaer anders-kiaer changed the title Fix inline markdown code highlighting Fixed syntax highlighting of code blocks in markdown Oct 8, 2021
Copy link
Collaborator

@asnyv asnyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@anders-kiaer anders-kiaer merged commit e3fa44b into equinor:master Oct 8, 2021
@anders-kiaer anders-kiaer deleted the code_highlight branch October 8, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working next release 🚢 To be included in next release
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Markdown plugin - code highlighting
2 participants