Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed setting of global log level for webviz application #440

Merged
merged 4 commits into from
May 6, 2021

Conversation

sigurdp
Copy link
Collaborator

@sigurdp sigurdp commented May 5, 2021

Fixed the way global log level specified through the --loglevel command line argument is applied in awebviz application.

@sigurdp sigurdp self-assigned this May 5, 2021
@sigurdp sigurdp marked this pull request as ready for review May 5, 2021 10:18
@anders-kiaer
Copy link
Collaborator

LGTM! 👍 Before we merge this, we should update the changelog (what is mentioned as unreleased in CHANGELOG.md in current master is recently released).

@anders-kiaer
Copy link
Collaborator

CHANGELOG.md updated - i.e. a rebase + update position of changelog entry should be enough and we can take this in 🐛 🐝

Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Specifying log level for webviz build does not work as expected
2 participants