Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support + test source_url/download_url combinations #435

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

anders-kiaer
Copy link
Collaborator

@anders-kiaer anders-kiaer commented Apr 29, 2021

Closes #431.

Copy link
Collaborator

@HansKallekleiv HansKallekleiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@anders-kiaer anders-kiaer force-pushed the fix_download_url_bug branch from 5e51bc3 to d1be7fa Compare April 29, 2021 13:14
@anders-kiaer anders-kiaer merged commit f4af971 into equinor:master Apr 29, 2021
@anders-kiaer anders-kiaer deleted the fix_download_url_bug branch April 29, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Download URL is needed if source URL is given in setup.py
2 participants