Added deprecation decorator #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rubenthoms
commented
Apr 15, 2021
rubenthoms
commented
- Sending deprecation warnings to frontend
- Implemented deprecation in documentation
- Added manual to CONTRIBUTING.md
rubenthoms
requested review from
anders-kiaer,
asnyv and
HansKallekleiv
as code owners
rubenthoms
force-pushed
the
add-deprecation-warning
branch
from
d001d29 to
2200880
Compare
|
Requires equinor/webviz-core-components#114 to be taken in. |
anders-kiaer
requested changes
Apr 16, 2021
There was a problem hiding this comment.
Nice work @rubenthoms 👍 This would be valuable, especially in the upcoming weeks/months when plugins in https://github.com/equinor/webviz-subsurface will be consolidated ✂️ Some feedback/suggestions below.
There was a problem hiding this comment.
Great @rubenthoms! 🍾 Important new functionality in less than 600 lines of code.
LGTM! 🌞 I think we are close of merging this in. Some comments below you can consider, most/all are minor only.
rubenthoms
force-pushed
the
add-deprecation-warning
branch
from
9109fbb to
7d4ae3a
Compare
- Added deprecation decorators - Added deprecation store - Added deprecation to auto documentation - Added deprecation to be shown in `WebvizPluginPlaceholder` component
rubenthoms
force-pushed
the
add-deprecation-warning
branch
from
7d4ae3a to
76aa599
Compare
Adjusted min required version of `webviz-core-components`
rubenthoms
force-pushed
the
add-deprecation-warning
branch
from
5943072 to
56260e5
Compare
- Changed import of deprecation_store - Renamed `webviz_deprecated` to `deprecation_decorators`
rubenthoms
force-pushed
the
add-deprecation-warning
branch
from
1bf274c to
6f3710e
Compare
anders-kiaer
approved these changes
Apr 27, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.