Skip multiple version of plugin warning if the metadata is equal #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anders-kiaer
previously requested changes
Jan 21, 2021
There was a problem hiding this comment.
Looks like a reasonable change👍
Maybe not the most common use case, but do we know what happens e.g. if:
webviz-config+webviz-subsurfaceis installed in system Python.- You create a venv with
--system-site-packages. - You source the venv and
pip install --upgrade webviz-config webviz-subsurface.
Will it currently give a warning (and then also after this one, if the --upgrade bumps the plugin package version)?
Comment on lines
+61
to
+69
| metadata[entry_point.name] = PluginDistInfo( | ||
| { | ||
| "dist_name": dist.metadata["name"], | ||
| "dist_version": dist.version, | ||
| "documentation_url": project_urls.get("Documentation"), | ||
| "download_url": project_urls.get("Download"), | ||
| "tracker_url": project_urls.get("Tracker"), | ||
| } | ||
| ) |
There was a problem hiding this comment.
Define this metadata dictionary once as a variable? Here it is introduced two times (more work to maintain)?
There was a problem hiding this comment.
I suggest just leaving the duplication for now. My upcoming and revised #377 ends up rewriting/moving this code so the duplication can removed then.
anders-kiaer
dismissed
their stale review
Requested change will be adressed by #377.
HansKallekleiv
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
CHANGELOG.md, and added it if should be communicated there.