Fix for import of TypedDict for Python versions older than 3.8 #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check against Python version instead of using try-except during import.
sigurdp
added
bug 🐛
sigurdp
requested review from
anders-kiaer,
asnyv and
HansKallekleiv
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way of importing TypedDict (for type hinting) using try-except seems to confuse mypy and causes errors during type checking. See for example in: https://github.com/equinor/webviz-subsurface/runs/1647251891?check_suite_focus=true
This PR fixes the issue by checking against Python version instead of using try-except during import.
See:
https://mypy.readthedocs.io/en/stable/common_issues.html#python-version-and-system-platform-checks
and:
python/typeshed#3500 (comment)
Also updated CHANGELOG to reflect the already published release 0.2.5