Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new pip resolver #289

Merged
merged 1 commit into from
Nov 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/webviz-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,12 @@ jobs:

- name: 📦 Install webviz-config with dependencies
run: |
pip install 'pandas==${{ matrix.pandas-version }}'
pip install --upgrade pip
pip install .
pip install --upgrade pip wheel
pip install --use-feature=2020-resolver . 'pandas==${{ matrix.pandas-version }}'

- name: 📦 Install test dependencies
run: |
pip install .[tests]
pip install dash[testing]
pip install --use-feature=2020-resolver .[tests]
wget https://chromedriver.storage.googleapis.com/$(wget https://chromedriver.storage.googleapis.com/LATEST_RELEASE -q -O -)/chromedriver_linux64.zip
unzip chromedriver_linux64.zip

Expand Down
4 changes: 0 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -515,11 +515,7 @@ To run tests it is necessary to first install the [selenium chrome driver](https
Then install the Python development requirements:
```bash
pip install .[tests]
pip install dash[testing]
```
The second of these commands appears to be necessary as long as
[this `pip` issue is open](https://github.com/pypa/pip/issues/4957).

You can then run the tests using
```bash
pytest tests --forked
Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ The recommended and simplest way of installing `webviz-config` is to run
pip install webviz-config
```

> :warning: Unless you are using `pip` version `>=20.3` you should enable the new `pip`
resolver when installing, i.e. `pip install --use-feature=2020-resolver webviz-config`.

If you want to develop `webviz-config` and install the latest source code manually you
can do something along the lines of:
can run
Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ def get_long_description() -> str:
TESTS_REQUIRES = [
"bandit",
"black",
"dash[testing]",
"jsonschema",
"mock",
"mypy",
Expand Down