Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from pkg_resources to importlib #281

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Change from pkg_resources to importlib #281

merged 1 commit into from
Sep 9, 2020

Conversation

anders-kiaer
Copy link
Collaborator

@anders-kiaer anders-kiaer commented Sep 5, 2020 •
edited
Loading

Change to more modern importlib.metadata wrt. entrypoints and version detection.

Contributor checklist

  • 🎉 This PR closes Consider using importlib instead of pkg_resources #185.
  • 📜 I have broken down my PR into the following tasks:
    • Change to importlib wrt. loading entrypoints.
    • Change to importlib wrt. detecting version.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@anders-kiaer anders-kiaer marked this pull request as ready for review September 5, 2020 18:59
@anders-kiaer anders-kiaer self-assigned this Sep 5, 2020
HansKallekleiv
HansKallekleiv approved these changes Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@HansKallekleiv HansKallekleiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anders-kiaer anders-kiaer merged commit 4f373a2 into equinor:master Sep 9, 2020
@anders-kiaer anders-kiaer deleted the importlib branch September 9, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansKallekleiv HansKallekleiv HansKallekleiv approved these changes

@asnyv asnyv Awaiting requested review from asnyv

Assignees

@anders-kiaer anders-kiaer

Labels
None yet
Projects
Webviz
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using importlib instead of pkg_resources
2 participants
@anders-kiaer @HansKallekleiv