Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use urls instead of tabs for main layout #230

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Use urls instead of tabs for main layout #230

merged 1 commit into from
Oct 6, 2020

Conversation

HansKallekleiv
Copy link
Collaborator

An attempt to replace current tab based page navigation with dcc.Location.

  • Components will require persistence as they are reloaded on page switching
  • Initial load of app should be must faster, but page switching might be somewhat slower

@HansKallekleiv HansKallekleiv mentioned this pull request May 4, 2020
Closed
@anders-kiaer anders-kiaer changed the title WIP: Use urls instead of tabs for main layout Use urls instead of tabs for main layout Aug 22, 2020
@anders-kiaer anders-kiaer marked this pull request as draft August 22, 2020 11:18
@anders-kiaer anders-kiaer mentioned this pull request Oct 5, 2020
Closed
6 tasks
@anders-kiaer anders-kiaer marked this pull request as ready for review October 6, 2020 10:00
asnyv
asnyv requested changes Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@asnyv asnyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a couple of details in the changelog text 🥇

@asnyv asnyv self-requested a review October 6, 2020 11:58
asnyv
asnyv approved these changes Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@asnyv asnyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@anders-kiaer anders-kiaer force-pushed the urls branch 3 times, most recently from 8c9483a to 4577d48 Compare October 6, 2020 12:10
@anders-kiaer anders-kiaer merged commit 7aaa6c8 into equinor:master Oct 6, 2020
This was referenced Oct 6, 2020
Merged
Closed
@anders-kiaer anders-kiaer mentioned this pull request Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnyv asnyv asnyv approved these changes

@anders-kiaer anders-kiaer Awaiting requested review from anders-kiaer

Assignees
No one assigned
Labels
None yet
Projects
Webviz
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HansKallekleiv @asnyv @anders-kiaer