Make ahmanalysis not use libres facade #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngve-sk
force-pushed
the
stop-using-ertconfig-ahmanalysis
branch
11 times, most recently
from
3bd0524 to
de659f8
Compare
oyvindeide
reviewed
Feb 9, 2025
...workflows/ahm_analysis/snapshots/test_integration/test_ahmanalysis_run_deactivated_obs/ks_df
Outdated
Show resolved
Hide resolved
yngve-sk
force-pushed
the
stop-using-ertconfig-ahmanalysis
branch
from
bd526dc to
05b1860
Compare
yngve-sk
force-pushed
the
stop-using-ertconfig-ahmanalysis
branch
from
05b1860 to
69a6795
Compare
oyvindeide
reviewed
Feb 18, 2025
yngve-sk
force-pushed
the
stop-using-ertconfig-ahmanalysis
branch
2 times, most recently
from
d265001 to
4ef555f
Compare
oyvindeide
approved these changes
Feb 19, 2025
|
|
||
| obs_keys = list(self.facade.get_observations().obs_vectors.keys()) | ||
| key_map = _group_observations(self.facade, obs_keys, group_by) | ||
| if not workflow_args: |
There was a problem hiding this comment.
Does this not default to empty list? If so, you can just have the else and skip this.
| prior_name, | ||
| target_name, | ||
| prior_experiment = prior_ensemble.experiment | ||
| assert prior_ensemble is not None |
There was a problem hiding this comment.
This should be above the previous line, and should give a better error message if we dont find an ensemble in storage.
| @@ -51,7 +52,7 @@ def test_ahmanalysis_run(snake_oil_facade): | |||
| ks_df = pd.read_csv(output_dir / "ks.csv") | |||
| for keys in ks_df["Parameters"].tolist(): | |||
| assert keys in parameters | |||
| assert ks_df.columns[1:].tolist() == group_obs | |||
| assert set(ks_df.columns[1:].tolist()) == set(group_obs) | |||
There was a problem hiding this comment.
The previous order is a bit arbitrary, and the All- usually come last in the dataframe as a consequence, I would opt for changing the test to be order agnostic rather than changing the order, though changing the order would be possible by sorting explicitly in make_obs_groups and then just putting those in there. Having the All* rows come last seems more sensible than a global sort to me at the moment.
yngve-sk
force-pushed
the
stop-using-ertconfig-ahmanalysis
branch
from
4ef555f to
44fcce3
Compare
yngve-sk
force-pushed
the
stop-using-ertconfig-ahmanalysis
branch
from
44fcce3 to
3452b08
Compare
yngve-sk
force-pushed
the
stop-using-ertconfig-ahmanalysis
branch
from
3452b08 to
5e2ab14
Compare
yngve-sk
force-pushed
the
stop-using-ertconfig-ahmanalysis
branch
from
5e2ab14 to
1ef1f6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #685