154 vulnerability scans accessible through api or grafana #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satr
reviewed
Feb 20, 2025
satr
reviewed
Feb 20, 2025
| rx get vulnerability --application radix-test --copmonent frontend | ||
|
|
||
| # Get a vulnerability scan results for job compute for an application radix-test, this also includes details about the vulnerability instead of a summary | ||
| rx get vulnerability --application radix-test --job compute |
There was a problem hiding this comment.
We do not distinguish between component and job-component in another commands, maybe job can be confusing with pipeline-job. Can we use job-component or just figure out this internally, using only component?
There was a problem hiding this comment.
Hmm, we could by sending a few api calls extra, but the vulnerability api is seperate for jobs vs components?
satr
reviewed
Feb 20, 2025
cmd/getVulnerability.go
Outdated
| os.Exit(2) | ||
| } | ||
| return nil | ||
| } else { |
satr
reviewed
Feb 20, 2025
Co-authored-by: Sergey Smolnikov <ssmol@equinor.com>
satr
previously approved these changes
Feb 21, 2025
Co-authored-by: Sergey Smolnikov <ssmol@equinor.com>
…r vulnerability scans
|
removed job flag and kept only component |
…or vulnerability scans
… improved clarity
satr
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary is shown on get application and get environment, when component or job is specified, full list of vulnerabilities is shown.