Updated version and api #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Richard87
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Ref. equinor/radix-github-actions#53 I dont think this solves it completley. He also struggled with unknown args when using the github action and linting problems.
The solution we talked about last time, even though not documented in the issue was to upgrade the action to:
- Install rx cli in the workflow
- Authenticate
So instead of one step to configure env variables for rx cli, and a different step to use rx action, use it to set up rx, and then just use it later on: run: rx create whatever (would also make the user experience more similar to the local experience 😃 )
If you agree, I can copy this into the other issue, if not maybe a new refinement of that issue is in order 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also fixes the issue