Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect test_cpu_seconds_can_detect_multiprocess #10233

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Mar 7, 2025

Issue
Resolves #10009

The test fails very often even with rerun=10, so it is simply incorrect and we should just remove it.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland
Copy link
Contributor

berland commented Mar 7, 2025

Has flakyness been observed since we tuned this function the last time (and we also skip it on Mac)

@eivindjahren
Copy link
Contributor Author

eivindjahren commented Mar 7, 2025

Has flakyness been observed since we tuned this function the last time (and we also skip it on Mac)

Last failure was here: https://github.com/equinor/ert/actions/runs/13671775651/job/38223383104 which was the day after the skip on mac change.

@eivindjahren eivindjahren enabled auto-merge (squash) March 7, 2025 10:23
Copy link

codspeed-hq bot commented Mar 7, 2025

CodSpeed Performance Report

Merging #10233 will not alter performance

Comparing eivindjahren:remove_non_working_test (72299c8) with main (07111bb)

Summary

✅ 25 untouched benchmarks

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@eivindjahren eivindjahren merged commit 4e6bd03 into equinor:main Mar 7, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:flaky-test-fix PR fixes a flaky test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Flaky test test_forward_model_step.py::test_cpu_seconds_can_detect_multiprocess
2 participants