Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where workflow context is tuples instead of lists #10227

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Fix bug where workflow context is tuples instead of lists #10227

merged 2 commits into from
Mar 6, 2025

Conversation

yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Mar 6, 2025

Backport of #10224

@berland berland changed the title backport workflow define bugfix Fix bug where workflow context is tuples instead of lists Mar 6, 2025
@berland
Copy link
Contributor

berland commented Mar 6, 2025

(changed title so that the automatic changelog will look pretty)

@yngve-sk yngve-sk enabled auto-merge (rebase) March 6, 2025 14:01
@yngve-sk yngve-sk merged commit 3c78204 into equinor:version-14.0 Mar 6, 2025
26 checks passed
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 6, 2025

CodSpeed Performance Report

Merging #10227 will improve performances by 13.95%

Comparing yngve-sk:25.backport-workflowdefine (f81877c) with main (1ec2095)

Summary

⚡ 2 improvements
✅ 23 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] 7.2 ms 6.3 ms +13.95%
⚡ test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_observations] 1.5 ms 1.4 ms +10.4%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland berland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yngve-sk @berland