fix: error message when variables are unsolvable #812
Merged
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch the error and convert it to an expected error. Further improvement could be to evaluate variables when needed, but it would still be nice if we could make sure we _can_ solve in validating.
TeeeJay
reviewed
Feb 27, 2025
src/libecalc/presentation/yaml/mappers/variables_mapper/variables_mapper.py
Show resolved
Hide resolved
TeeeJay
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch the error and convert it to an expected error.
Further improvement could be to evaluate variables when needed, but it
would still be nice if we could make sure we can solve in
validating.