fix: issue with empty optional keywords #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsolaas
force-pushed
the
fix/yaml-validation-type-error
branch
from
ace34aa to
a498551
Compare
If specifying only a keyword without the data for an optional keyword in the yaml we would not get a validation error. I.e. the json-schema did not capture the error. In addition, the validation context setup did not account for None in the data, expecting either unset or some data (not None). This caused a type error since we then tried to use None as a list. Adding only `MODELS:` to the yaml would reproduce the error. Removing `MODELS:` or adding an empty list `MODELS: []` would make it valid.
jsolaas
force-pushed
the
fix/yaml-validation-type-error
branch
from
a498551 to
f081d6f
Compare
TeeeJay
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If specifying only a keyword without the data for an optional keyword in
the yaml we would not get a validation error. I.e. the json-schema did
not capture the error. In addition, the validation context setup did not
account for None in the data, expecting either unset or some data (not
None). This caused a type error since we then tried to use None as a
list.
Adding only
MODELS:to the yaml would reproduce the error. RemovingMODELS:or adding an empty listMODELS: []would make it valid.