chore: include invalid results for pump models #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ECALC-799
# Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # interactive rebase in progress; onto 0879cec # Last commands done (3 commands done): # pick 5193678 test: update snapshots and tests # pick 4529b32 chore: update snapshots to work with periods # Next commands to do (7 remaining commands): # pick 3910cd4 chore: include invalid data in pump model plot # pick 4811a8e chore: update tests # You are currently rebasing branch 'ECALC-799' on '0879cecc'. # # Changes to be committed: # modified: src/libecalc/domain/process/core/results/pump.py # modified: src/libecalc/domain/process/pump/pump.py # modified: tests/libecalc/core/consumers/system/conftest.py #
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #431
Why is this pull request needed?
The lower-level results currently differ between ‘compressors’ and ‘pumps’. For compressors the results for calculations with invalid points are included, but not for pumps.
What does this pull request change?
Invalid results are returned (with a failure status flag) for pump models also