Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs bug #336

Merged
merged 5 commits into from
Jun 2, 2020
Merged

Tabs bug #336

merged 5 commits into from
Jun 2, 2020

Conversation

vnys
Copy link
Member

@vnys vnys commented May 31, 2020 •
edited
Loading

@vnys vnys added core-react eds-core-react bug-fix labels May 31, 2020
@vnys vnys requested a review from mimarz as a code owner May 31, 2020 15:39
@vnys vnys self-assigned this May 31, 2020
@vnys vnys mentioned this pull request May 31, 2020
Closed
mimarz
mimarz suggested changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small edge case maybe?

mimarz
mimarz approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vnys vnys merged commit b0485d4 into equinor:develop Jun 2, 2020
@vnys vnys deleted the tabs-bug branch June 2, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

Assignees

@vnys vnys

Labels
core-react eds-core-react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabs component steals focus on render
2 participants
@vnys @mimarz