Fix klusolve install #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This installs the klusolve library, needed by the main executable. It uses GNUInstallDirs for Linux and allows the user to specify a CMAKE_INSTALL_PREFIX from the command line or via preset if desired. Signed-off-by: Ed Beroset <beroset@ieee.org>
This adds CPack to allow building a package. It should be augmented to include a proper license file. Signed-off-by: Ed Beroset <beroset@ieee.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This installs the needed
klusolve_alllibrary, adds CPack to allow for the user to create a package (e.g. withcmake --build build -t package) and removes the explicit destination directory to install the main executable in favor of using GNUInstallDirs for the Linux version. The install destination is settable from the command line anyway or via CMake presets, by setting the value of CMAKE_BUILD_PREFIX. This results in a usable.shinstaller under Linux and still allows Windows users to explicitly set the installation directory for both the executable and the library.