feat: added accordion component #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aamialkovich
requested changes
Mar 5, 2025
| @@ -0,0 +1,50 @@ | |||
| .example-accordion { | |||
There was a problem hiding this comment.
Could you please get rid of example prefix as it is common component.
There was a problem hiding this comment.
I believe we should focus on Tailwind-based development to maintain a consistent codebase.
ui/package-lock.json
Outdated
There was a problem hiding this comment.
Seems it is not needed as package.json wasn't updated.
| </button> | ||
| @if(accordionItem.expanded) { | ||
| <div class="p-4" role="region" [style.display]="accordionItem.expanded ? '' : 'none'" | ||
| [attr.id]="'accordion-body-' + index" [attr.aria-labelledby]="'accordion-header-' + index" [innerHTML]="item.description"> |
There was a problem hiding this comment.
Please get rid of innerHTML and use angular content projection like in modal.component
| templateUrl: './accordion.component.html' | ||
| }) | ||
| export class AccordionComponent { | ||
| items = [{title: 'Item 1', description: '<table><thead><tr><th>Header 1</th><th>Header 2</th><th>Header 3</th></tr></thead><tbody><tr><td>Data 1</td><td>Data 2</td><td>Data 3</td></tr></tbody></table>'}, |
There was a problem hiding this comment.
No need to put items here. As this is single accordion component, we can rely only on title as angular input here and content which will be passed to this accordion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.