Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Envoy to 592868a (Oct 18, 2021) #753

Closed
wants to merge 7 commits into from

Conversation

eric846
Copy link
Contributor

@eric846 eric846 commented Oct 19, 2021

  • Update .bazelrc
  • Update .bazelversion
  • Update after DNS resolver changes in Refactoring Envoy DNS resolution as extension envoy#17479
    • Note: A DNS resolver factory layer has been added since earlier versions of the Envoy PR.
    • The reason ProcessImpl receives an injected DNS resolver factory instead of a DNS resolver is that the complicated api the factory needs to work is only constructed later (in the ProcessImpl constructor).
    • Note: createDefaultDnsResolverFactory() creates the platform-specific factory and also has the side effect of populating the TypedExtensionConfig.
    • Note: The createDnsResolver() method on the DNS resolver factory also takes the TypedExtensionConfig as an input. So in addition to injecting the factory into ProcessImpl, we also need to inject the TypedExtensionConfig that was populated by createDefaultDnsResolverFactory().

tomjzzhang and others added 7 commits October 18, 2021 16:42
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants