Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix docs for RBE configs #9356

Merged
merged 1 commit into from
Dec 15, 2019
Merged

Conversation

lizan
Copy link
Member

@lizan lizan commented Dec 15, 2019

Signed-off-by: Lizan Zhou lizan@tetrate.io

Description:
This is broken in #8906 because extension db is loaded outside Bazel. cc @htuch.

Risk Level: Low
Testing: local
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested a review from mattklein123 December 15, 2019 09:10
Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my setup and it works fine now. Thanks!

@mattklein123
Copy link
Member

Awesome, thanks so much for fixing. RBE for the win!

@mattklein123 mattklein123 merged commit ff017c4 into envoyproxy:master Dec 15, 2019
prakhag1 pushed a commit to prakhag1/envoy that referenced this pull request Jan 3, 2020
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Prakhar <prakhar_au@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants