server: provide server health status when stats disabled #8482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venilnoronha
changed the title
venilnoronha
force-pushed
the
fix-server-live
branch
from
d5a3b82 to
52ea2fb
Compare
jmarantz
reviewed
Oct 11, 2019
jmarantz
previously approved these changes
Oct 21, 2019
|
@envoyproxy/senior-maintainers |
Signed-off-by: Venil Noronha <veniln@vmware.com>
Signed-off-by: Venil Noronha <veniln@vmware.com>
* Create a `request` utility function * Import `testing` functions via `using` Signed-off-by: Venil Noronha <veniln@vmware.com>
venilnoronha
force-pushed
the
fix-server-live
branch
from
011c826 to
e86dae0
Compare
|
@venilnoronha please do not force push, thank you! |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattklein123
approved these changes
Oct 23, 2019
|
@mattklein123 I had to force push coz I rebased this branch with master. Will merge next time on. |
spenceral
added a commit
to spenceral/envoy
that referenced
this pull request
Oct 23, 2019
* master: (54 commits) Update dependencies - Go, Bazel toos, xxHash, nanopb, rules_go, curl, protobuf, Jinja, yaml-cpp, re2 (envoyproxy#8728) test: increase coverage of listener_manager_impl.cc (envoyproxy#8737) test: modify some macros to reduce number of uncovered lines reported (envoyproxy#8725) build: add a script to setup clang (envoyproxy#8682) http: fix ssl_redirect on external (envoyproxy#8664) docs: update fedora build requirements (envoyproxy#8641) fix draining listener removal logs (envoyproxy#8733) dubbo: fix router doc (envoyproxy#8734) server: provide server health status when stats disabled (envoyproxy#8482) router: adding a knob to configure a cap on buffering for shadowing/retries (envoyproxy#8574) tcp proxy: add default 1 hour idle timeout (envoyproxy#8705) thrift: fix filter names in docs (envoyproxy#8726) Quiche changes to avoid gcc flags on Windows (envoyproxy#8514) test: increase test coverage in Router::HeaderParser (envoyproxy#8721) admin: add drain listeners endpoint (envoyproxy#8415) buffer filter: add content-length when ending stream with trailers (envoyproxy#8609) clarify draining option docs (envoyproxy#8712) build: ignore go-control-plane mirror git commit error code (envoyproxy#8703) api: remove API type database from checked in artifacts. (envoyproxy#8716) admin: correct help strings (envoyproxy#8710) ... Signed-off-by: Spencer Lewis <slewis@squareup.com>
derekargueta
pushed a commit
to derekargueta/envoy
that referenced
this pull request
Oct 24, 2019
…8482) Signed-off-by: Venil Noronha <veniln@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This fixes a bug where the server health check returns an incorrect response when server stats are disabled i.e. due to relying on the
server.livegauge.Risk Level: Low
Testing: Added a new test
Docs Changes: N/A
Release Notes: N/A
Fixes #8473