Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add comprehensive coverage reporting to router check #7865

Merged
merged 5 commits into from
Aug 14, 2019

Conversation

dschaller
Copy link
Member

Description: add comprehensive coverage reporting to the router check tool.
Risk Level: Low
Testing: Added tests and manually tested
Docs Changes: Included
Release Notes: Included

Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
@dschaller dschaller closed this Aug 8, 2019
Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
@dschaller dschaller reopened this Aug 8, 2019
@dschaller
Copy link
Member Author

/wait

Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
@dschaller
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: clang_tidy (failed build)

🐱

Caused by: a #7865 (comment) was created by @dschaller.

see: more, trace.

@dschaller
Copy link
Member Author

@dio @rgs1 @mattklein123 @jyotima mind taking a look at this? It’s an expansion off of #7727

@mattklein123 mattklein123 self-assigned this Aug 12, 2019
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks good stuff, some small comments. It would pretty cool if there was some other way of tracking per-field coverage that was more built-in and less manual, but I can't think of anything.

/wait

Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
@dschaller
Copy link
Member Author

Yeah, I was hoping that it would be possible to make this less manual but couldn't think of anything that was promising. I'm especially not a fan of the vector of coverageFIelds but couldn't find an alternative.

On the plus side this increases visibility into what fields on routes are covered. 🎉

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 71a679d into envoyproxy:master Aug 14, 2019
@dschaller dschaller deleted the routercheckfieldcoverage branch August 14, 2019 19:03
@jyotimahapatra
Copy link
Contributor

#730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants