-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add comprehensive coverage reporting to router check #7865
tools: add comprehensive coverage reporting to router check #7865
Conversation
Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
/wait |
Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
/retest |
🔨 rebuilding |
@dio @rgs1 @mattklein123 @jyotima mind taking a look at this? It’s an expansion off of #7727 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks good stuff, some small comments. It would pretty cool if there was some other way of tracking per-field coverage that was more built-in and less manual, but I can't think of anything.
/wait
Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
Yeah, I was hoping that it would be possible to make this less manual but couldn't think of anything that was promising. I'm especially not a fan of the vector of On the plus side this increases visibility into what fields on routes are covered. 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description: add comprehensive coverage reporting to the router check tool.
Risk Level: Low
Testing: Added tests and manually tested
Docs Changes: Included
Release Notes: Included