Add support in route checker tool for runtimes in routes #7418
Conversation
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
|
@mattklein123 I will update the docs if the general approach looks right. |
jyotimahapatra
changed the title
| @@ -65,6 +65,9 @@ message ValidationInput { | |||
| // The “:authority”, “:path”, “:method”, “x-forwarded-proto”, and “x-envoy-internal” fields are | |||
| // specified by the other config options and should not be set here. | |||
| repeated envoy.api.v2.core.HeaderValue additional_headers = 8; | |||
|
|
|||
| // Enable a runtime flag | |||
There was a problem hiding this comment.
Don't you want to allow a percentage here so that the user can test different decisions? I'm a little confused about the semantics. Can you clarify in the documentation more?
There was a problem hiding this comment.
@mattklein123 The percentage is guided by the existing random_value property. I have added a test to demonstrate this.
There was a problem hiding this comment.
Makes sense, thanks. Can you add more docs here to indicate that the random_value property is used to effect the settings?
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
| @@ -65,6 +65,9 @@ message ValidationInput { | |||
| // The “:authority”, “:path”, “:method”, “x-forwarded-proto”, and “x-envoy-internal” fields are | |||
| // specified by the other config options and should not be set here. | |||
| repeated envoy.api.v2.core.HeaderValue additional_headers = 8; | |||
|
|
|||
| // Enable a runtime flag | |||
There was a problem hiding this comment.
Makes sense, thanks. Can you add more docs here to indicate that the random_value property is used to effect the settings?
|
@mattklein123 I added some more explanation in the comments. |
Signed-off-by: Jyoti Mahapatra jmahapatra@lyft.com
Description: Support testing routes with runtimes
Risk Level: Low
Testing: Added test cases for the route checker tool
Docs Changes:
Release Notes:
[Optional Fixes #Issue] #7264 #730