tracer: Added tests for casting to HttpTracerImpl #5250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
changed the title
mattklein123
approved these changes
Dec 9, 2018
| EXPECT_EQ(nullptr, dynamic_cast<Tracing::HttpNullTracer*>(&server_->httpContext().tracer())); | ||
| EXPECT_EQ(nullptr, dynamic_cast<Tracing::HttpNullTracer*>(tracer())); | ||
|
|
||
| // Note: there is no ZipkingTracerImpl object; |
There was a problem hiding this comment.
You could probably expose the underlying driver somehow and dynamic cast to that, but not sure it's worth it.
There was a problem hiding this comment.
I thought of that and also felt like that was overkill. Really the way to go deeper on this is to have a zipkin integration test that shows zipkin syntax coming out of the server. But for the resolution of #5241 I really wanted something that just looked at the tracer field.
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Follow-up to envoyproxy#5249 adding tests for being able to cast the tracer to HttpTracerImpl when zipkin is configured. Signed-off-by: Joshua Marantz <jmarantz@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: follow-up to #5249 adding tests for being able to cast to HttpTracerImpl.
Risk Level: low
Testing: //test/server:server_test
Docs Changes: n/a
Release Notes: n/a