docs: improve gRPC-JSON filter doc #4184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ctoomey <ctoomey@livongo.com>
lizan
reviewed
Aug 16, 2018
| static_resources: | ||
| listeners: | ||
| - name: listener1 |
There was a problem hiding this comment.
I don't think you need this, listener2 can serve both gRPC and its RESTful JSON mapping.
There was a problem hiding this comment.
Good to know, didn't realize that. Will simplify the config.
Signed-off-by: ctoomey <ctoomey@livongo.com>
lizan
reviewed
Aug 16, 2018
There was a problem hiding this comment.
Thanks to taking up this! The sample LGTM, will defer to @mattklein123 or other maintainer for wordsmithing.
| - name: envoy.grpc_json_transcoder | ||
| config: | ||
| proto_descriptor: "/tmp/envoy/proto.pb" |
| services: ["HelloWorld"] | ||
| print_options: | ||
| add_whitespace: true |
Signed-off-by: ctoomey <ctoomey@livongo.com>
|
Fixed config spacing |
Signed-off-by: ctoomey <ctoomey@livongo.com>
snowp
pushed a commit
to snowp/envoy
that referenced
this pull request
Aug 20, 2018
* origin/master: (34 commits) fuzz: fixes oss-fuzz: 9895 (envoyproxy#4189) docs: added developer docs for pprof/tcmalloc testing (envoyproxy#4194) fix sometimes returns response body to HEAD requests (envoyproxy#3985) admin: fix config dump order (envoyproxy#4197) thrift: allow translation between downstream and upstream protocols (envoyproxy#4136) Use local_info.node() instead of bootstrap.node() whenever possible (envoyproxy#4120) upstream: allow extension protocol options to be used with http filters (envoyproxy#4165) [thrift_proxy] Replace local HeaderMap with Http::HeaderMap[Impl] (envoyproxy#4169) docs: improve gRPC-JSON filter doc (envoyproxy#4184) stats: refactoring MetricImpl without strings (envoyproxy#4190) fuzz: coverage profile generation instructions. (envoyproxy#4193) upstream: rebuild cluster when health check config is changed (envoyproxy#4075) build: use clang-6.0. (envoyproxy#4168) thrift_proxy: introduce header transport (envoyproxy#4082) tcp: allow connection pool callers to store protocol state (envoyproxy#4131) configs: match latest API changes (envoyproxy#4185) Fix wrong mock function name. (envoyproxy#4187) Bump yaml-cpp so it builds with Visual Studio 15.8 (envoyproxy#4182) Converting envoy configs to V2 (envoyproxy#2957) Add timestamp to HealthCheckEvent definition (envoyproxy#4119) ... Signed-off-by: Snow Pettersen <snowp@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ctoomey ctoomey@livongo.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: improve gRPC-JSON filter doc
Risk Level: Low
Testing: Viewed doc on github
Docs Changes: Added link to protobuf JSON mapping, added doc for how stream request/response params handled, added sample config
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]