Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: use GCS remote cache #4050

Merged
merged 12 commits into from
Aug 12, 2018
Merged

bazel: use GCS remote cache #4050

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
72f153e
bazel: use GCS remote cache
lizan Aug 3, 2018
757581c
setup read-only cache where key is not available
lizan Aug 3, 2018
c297830
Merge remote-tracking branch 'upstream/master' into ci_gcs_remote_cache
lizan Aug 4, 2018
ddcc25d
move env variables to circleci.yaml
lizan Aug 6, 2018
6ec7ebf
Merge remote-tracking branch 'upstream/master' into ci_gcs_remote_cache
lizan Aug 7, 2018
e49e7db
Empty commit to trigger CI again
lizan Aug 7, 2018
58fcfdf
Merge remote-tracking branch 'upstream/master' into ci_gcs_remote_cache
lizan Aug 7, 2018
e4f2dd4
remove blank lines
lizan Aug 7, 2018
9f415e8
Merge remote-tracking branch 'upstream/master' into ci_gcs_remote_cache
lizan Aug 7, 2018
2c95de0
Merge remote-tracking branch 'upstream/master' into ci_gcs_remote_cache
lizan Aug 8, 2018
7a79526
disable cache for coverage
lizan Aug 10, 2018
877957c
Merge remote-tracking branch 'upstream/master' into ci_gcs_remote_cache
lizan Aug 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/do_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ if [[ "$1" == "fix_format" || "$1" == "check_format" ]]; then
build_setup_args="-nofetch"
fi

. "$(dirname "$0")"/setup_gcs_cache.sh
. "$(dirname "$0")"/build_setup.sh $build_setup_args

echo "building using ${NUM_CPUS} CPUs"
Expand Down
4 changes: 3 additions & 1 deletion ci/mac_ci_steps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

set -e

BAZEL_BUILD_OPTIONS="--curses=no --show_task_finish --verbose_failures"
. "$(dirname "$0")"/setup_gcs_cache.sh

BAZEL_BUILD_OPTIONS="--curses=no --show_task_finish --verbose_failures ${BAZEL_BUILD_EXTRA_OPTIONS}"
# TODO(zuercher): remove --flaky_test_attempts when https://github.com/envoyproxy/envoy/issues/2428
# is resolved.
BAZEL_TEST_OPTIONS="${BAZEL_BUILD_OPTIONS} --test_output=all --flaky_test_attempts=integration@2"
Expand Down
19 changes: 19 additions & 0 deletions ci/setup_gcs_cache.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#!/bin/bash

set -e

gcp_service_account_cleanup() {
echo "Deleting service account key file..."
rm -rf /tmp/gcp_service_account.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use TMPDIR or something, probably bad to assume the existent of /tmp.

}

if [[ ! -z "${GCP_SERVICE_ACCOUNT_KEY}" && ! -z "${BAZEL_REMOTE_CACHE}" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to grab me on slack and I can setup the env variables for you so we can test this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to add those env variables to CircleCI

echo "${GCP_SERVICE_ACCOUNT_KEY}" | base64 --decode > /tmp/gcp_service_account.json
trap gcp_service_account_cleanup EXIT

export BAZEL_BUILD_EXTRA_OPTIONS="${BAZEL_BUILD_EXTRA_OPTIONS} \
--remote_http_cache=${BAZEL_REMOTE_CACHE} --google_credentials=/tmp/gcp_service_account.json"
echo "Set up bazel HTTP cache at ${BAZEL_REMOTE_CACHE}."
else
echo "No GCP service account key or remote cache bucket is set, skipping setup remote cache."
fi