lc trie: add exclusive flag. #3825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Risk Level*: Low *Testing*: bazel test //test/... *Docs Changes*: n/a *Release Notes*: n/a Signed-off-by: Piotr Sikora <piotrsikora@google.com>
|
cc @brian-pane |
ccaraman
previously approved these changes
Jul 10, 2018
There was a problem hiding this comment.
@PiotrSikora should the exclusive flag be exposed in the filter to enable/disable?
|
@ccaraman You mean in the IP tagging filter? It could be useful there (e.g. if tags are used for geolocation), but - assuming that you guys are using it - you should probably know better than me. I'm happy to add it if you think it's going to be useful for you, but I'd rather not block this PR on it. FWIW, I'm going to use this for destination IP matching in the filter chains. |
brian-pane
previously approved these changes
Jul 10, 2018
source/common/network/lc_trie.h
Outdated
| @@ -309,7 +311,7 @@ template <class T> class LcTrie { | |||
| */ | |||
| template <class IpType, uint32_t address_size = CHAR_BIT * sizeof(IpType)> class BinaryTrie { | |||
| public: | |||
| BinaryTrie() : root_(std::make_unique<Node>()) {} | |||
| BinaryTrie(bool exclusive) : root_(std::make_unique<Node>()), exclusive_(exclusive) {} | |||
|
|
|||
| /** | |||
| * Add a CIDR prefix and associated tag to the binary trie. If an entry already | |||
There was a problem hiding this comment.
[minor] You might want to s/tag/data/g in this comment for consistency with the new nomenclature.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
|
@brian-pane I did mass replace, looks that I've missed bunch in the original commit. |
|
Friendly ping, since this was already approved twice (sans |
brian-pane
approved these changes
Jul 12, 2018
mattklein123
approved these changes
Jul 12, 2018
snowp
pushed a commit
to snowp/envoy
that referenced
this pull request
Jul 12, 2018
* origin/master: config: making v2-config-only a boolean flag (envoyproxy#3847) lc trie: add exclusive flag. (envoyproxy#3825) upstream: introduce PriorityStateManager, refactor EDS (envoyproxy#3783) test: deflaking header_integration_test (envoyproxy#3849) http: new style WebSockets, where headers and data are processed by the filter chain. (envoyproxy#3776) common: minor doc updates (envoyproxy#3845) fix master build (envoyproxy#3844) logging: Requiring details for RELEASE_ASSERT (envoyproxy#3842) test: add test for consistency of RawStatData internal memory representation (envoyproxy#3843) common: jittered backoff implementation (envoyproxy#3791) format: run buildifier on .bzl files. (envoyproxy#3824) Support mutable metadata for endpoints (envoyproxy#3814) test: deflaking a test, improving debugability (envoyproxy#3829) Update ApiConfigSource docs with grpc_services only for GRPC configs (envoyproxy#3834) Add hard-coded /hot_restart_version test (envoyproxy#3832) healthchecks: Add interval_jitter_percent healthcheck option (envoyproxy#3816) Signed-off-by: Snow Pettersen <snowp@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there, replace remaining "tags" with "data".
Risk Level: Low
Testing: bazel test //test/...
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Piotr Sikora piotrsikora@google.com