test: tweaks to uds_integration_test (--runs_per_test) #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
changed the title
alyssawilk
changed the title
htuch
previously approved these changes
Jul 3, 2018
| @@ -14,6 +14,15 @@ | |||
| #include "gtest/gtest.h" | |||
|
|
|||
| namespace Envoy { | |||
|
|
|||
| std::string udsSocketName(const std::string& path, bool abstract_namespace) { | |||
| const std::string name = TestEnvironment::unixDomainSocketPath(path); | |||
There was a problem hiding this comment.
Arguably we could move this into TestEnvironment::unixDomainSocketPath.
mattklein123
previously approved these changes
Jul 3, 2018
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to debug a ci flake of uds integration test. Haven't managed to repo the flake even with 5k asan runs, but I figure it's worth allowing the parallelism.
Risk Level: n/a (test only)
Testing: uds test now runs with --runs_per_test > 1
Docs Changes: n/a
Release Notes: n/a