Fixes #3756 by creating a new api_proto_library_internal build rule that #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htuch
suggested changes
Jun 29, 2018
api/bazel/api_build_system.bzl
Outdated
| @@ -74,6 +74,17 @@ def api_go_grpc_library(name, proto, deps = []): | |||
| ] | |||
| ) | |||
|
|
|||
| # This is api_proto_library plus some logic internal to //envoy/api. | |||
| def api_proto_library_internal(name, visibility = ["//visibility:private"], srcs = [], deps = [], has_services = 0, require_py = 1): | |||
There was a problem hiding this comment.
You can use **kwargs to pass-thru args that aren't explicitly used in the method body (it's basically like Python).
There was a problem hiding this comment.
Done. Please take another look.
…ild rule that adds the required visibility rules and delegates the rest to the generic api_proto_library. I tested the change by doing the following without getting errors. ./ci/run_envoy_docker.sh './ci/do_ci.sh docs' I changed the BUILD files using the following commands. /envoy/api$ find . -type f -name BUILD | xargs sed -i -e 's/api_proto_library(/api_proto_library_internal(/g' envoy/api$ find . -type f -name BUILD | xargs sed -i -e 's/"api_proto_library"/"api_proto_library_internal"/g' Signed-off-by: mickey <mickeyju@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the required visibility rules and delegates the rest to the generic
api_proto_library. I tested the change by doing the following without
getting errors.
./ci/run_envoy_docker.sh './ci/do_ci.sh docs'
I changed the BUILD files using the following commands.
/envoy/api$ find . -type f -name BUILD | xargs sed -i -e 's/api_proto_library(/api_proto_library_internal(/g'
envoy/api$ find . -type f -name BUILD | xargs sed -i -e 's/"api_proto_library"/"api_proto_library_internal"/g'
Signed-off-by: mickey mickeyju@google.com